alamb commented on issue #13519: URL: https://github.com/apache/datafusion/issues/13519#issuecomment-3029293964
> In light of a push to reduce breaking changes like https://github.com/apache/datafusion/issues/16622 (and https://github.com/apache/datafusion/pull/16078, https://github.com/apache/datafusion/pull/16541, https://github.com/apache/datafusion/issues/13648) we could try to be more judicious about growing the public API. IF we don't need to expose full SessionConfig / ConfigOptions in ScalarFunctionArgs let's maybe not expose them. My counter argument is that having to add new fields to ExecutionProps basically increases the public API over time. `ConfigOptions` is already public so it is my opinion that exposing just the `ConfigOptions` is less API surface area. I can see how there are alternate opinions to this Here is what passing in the entire ConfigOptions looks like (it is pretty straightforward actually): https://github.com/apache/datafusion/pull/16661 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
