jayzhan211 commented on PR #14826:
URL: https://github.com/apache/datafusion/pull/14826#issuecomment-2757360811
Thanks @Chen-Yuan-Lai
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
jayzhan211 merged PR #14826:
URL: https://github.com/apache/datafusion/pull/14826
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dat
jayzhan211 commented on code in PR #14826:
URL: https://github.com/apache/datafusion/pull/14826#discussion_r2013954619
##
datafusion/sqllogictest/test_files/string/string_view.slt:
##
@@ -1068,7 +1068,7 @@ EXPLAIN SELECT
FROM test;
logical_plan
-01)Projection: digest(tes
jayzhan211 commented on PR #14826:
URL: https://github.com/apache/datafusion/pull/14826#issuecomment-2754084860
you can mark it ready for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
Chen-Yuan-Lai commented on PR #14826:
URL: https://github.com/apache/datafusion/pull/14826#issuecomment-2753751909
@jayzhan211 I think the PR is ready to be reviewed :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
Chen-Yuan-Lai commented on code in PR #14826:
URL: https://github.com/apache/datafusion/pull/14826#discussion_r2013574522
##
datafusion/functions/src/crypto/basic.rs:
##
@@ -328,6 +322,37 @@ impl DigestAlgorithm {
}
}
}
+
+pub fn digest_binary_arra
Chen-Yuan-Lai commented on code in PR #14826:
URL: https://github.com/apache/datafusion/pull/14826#discussion_r1988897840
##
datafusion/functions/src/crypto/sha512.rs:
##
@@ -52,11 +56,16 @@ impl Default for SHA512Func {
impl SHA512Func {
pub fn new() -> Self {
-
Chen-Yuan-Lai commented on code in PR #14826:
URL: https://github.com/apache/datafusion/pull/14826#discussion_r1988897840
##
datafusion/functions/src/crypto/sha512.rs:
##
@@ -52,11 +56,16 @@ impl Default for SHA512Func {
impl SHA512Func {
pub fn new() -> Self {
-
Chen-Yuan-Lai commented on code in PR #14826:
URL: https://github.com/apache/datafusion/pull/14826#discussion_r1988897840
##
datafusion/functions/src/crypto/sha512.rs:
##
@@ -52,11 +56,16 @@ impl Default for SHA512Func {
impl SHA512Func {
pub fn new() -> Self {
-
jayzhan211 commented on code in PR #14826:
URL: https://github.com/apache/datafusion/pull/14826#discussion_r1986495558
##
datafusion/functions/src/crypto/sha512.rs:
##
@@ -52,11 +56,16 @@ impl Default for SHA512Func {
impl SHA512Func {
pub fn new() -> Self {
-use
jayzhan211 commented on code in PR #14826:
URL: https://github.com/apache/datafusion/pull/14826#discussion_r1986495558
##
datafusion/functions/src/crypto/sha512.rs:
##
@@ -52,11 +56,16 @@ impl Default for SHA512Func {
impl SHA512Func {
pub fn new() -> Self {
-use
jayzhan211 commented on code in PR #14826:
URL: https://github.com/apache/datafusion/pull/14826#discussion_r1986494416
##
datafusion/functions/src/crypto/basic.rs:
##
@@ -342,22 +367,27 @@ pub fn digest_process(
DataType::LargeBinary => {
digest_alg
jayzhan211 commented on code in PR #14826:
URL: https://github.com/apache/datafusion/pull/14826#discussion_r1986494305
##
datafusion/functions/src/crypto/basic.rs:
##
@@ -328,6 +322,37 @@ impl DigestAlgorithm {
}
}
}
+
+pub fn digest_binary_array_i
Chen-Yuan-Lai commented on code in PR #14826:
URL: https://github.com/apache/datafusion/pull/14826#discussion_r1986347452
##
datafusion/functions/src/crypto/basic.rs:
##
@@ -328,6 +322,37 @@ impl DigestAlgorithm {
}
}
}
+
+pub fn digest_binary_arra
Chen-Yuan-Lai commented on code in PR #14826:
URL: https://github.com/apache/datafusion/pull/14826#discussion_r1986346839
##
datafusion/functions/src/crypto/basic.rs:
##
@@ -342,22 +367,27 @@ pub fn digest_process(
DataType::LargeBinary => {
digest_
Chen-Yuan-Lai commented on PR #14826:
URL: https://github.com/apache/datafusion/pull/14826#issuecomment-2708900254
> Hi @jayzhan211, It seems all the CI checks were passed (including
sqlogicaltest), but when I created and printed a table by datafusion-cli , I
got empty result
>
> ```
Chen-Yuan-Lai commented on PR #14826:
URL: https://github.com/apache/datafusion/pull/14826#issuecomment-2708661495
Hi @jayzhan211, It seems all the CI checks were passed (including
sqlogicaltest), but when I created and printed a table table by datafusion-cli
, I got empty result
```
alamb commented on PR #14826:
URL: https://github.com/apache/datafusion/pull/14826#issuecomment-2695599719
CI appears to be failing, so marking this one as a draft
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
jayzhan211 commented on PR #14826:
URL: https://github.com/apache/datafusion/pull/14826#issuecomment-2680085289
> [SQL] EXPLAIN SELECT
digest(column1_utf8view, 'md5') as c
FROM test;
[Diff] (-expected|+actual)
logical_plan
- 01)Projection: digest(test.column1_utf8view,
Chen-Yuan-Lai commented on PR #14826:
URL: https://github.com/apache/datafusion/pull/14826#issuecomment-2679115258
Hi @jayzhan211, I encountered some CI failures in the `digest` function. It
seems the `Exact(vec![Utf8View, Utf8View])` case can't be replaced with
`TypeSignature::Coercible` b
Chen-Yuan-Lai opened a new pull request, #14826:
URL: https://github.com/apache/datafusion/pull/14826
## Which issue does this PR close?
- Closes #14762 .
## Rationale for this change
## What changes are included in this PR?
## Are these cha
21 matches
Mail list logo
