jayzhan211 commented on code in PR #14826:
URL: https://github.com/apache/datafusion/pull/14826#discussion_r1986494305
##########
datafusion/functions/src/crypto/basic.rs:
##########
@@ -328,6 +322,37 @@ impl DigestAlgorithm {
}
}
}
+
+ pub fn digest_binary_array_impl<'a, BinaryArrType>(
+ self,
+ input_value: BinaryArrType,
+ ) -> ArrayRef
+ where
+ BinaryArrType: BinaryArrayType<'a>,
+ {
+ match self {
+ Self::Md5 => digest_to_array!(Md5, input_value),
+ Self::Sha224 => digest_to_array!(Sha224, input_value),
+ Self::Sha256 => digest_to_array!(Sha256, input_value),
+ Self::Sha384 => digest_to_array!(Sha384, input_value),
+ Self::Sha512 => digest_to_array!(Sha512, input_value),
+ Self::Blake2b => digest_to_array!(Blake2b512, input_value),
+ Self::Blake2s => digest_to_array!(Blake2s256, input_value),
+ Self::Blake3 => {
+ let binary_array: BinaryArray = input_value
+ .iter()
+ .map(|opt| {
+ opt.map(|x| {
+ let mut digest = Blake3::default();
+ digest.update(x);
+ Blake3::finalize(&digest).as_bytes().to_vec()
+ })
+ })
+ .collect();
+ Arc::new(binary_array)
+ }
+ }
+ }
Review Comment:
It would be nice to
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
