comphead commented on PR #14332:
URL: https://github.com/apache/datafusion/pull/14332#issuecomment-2622109979
> One way to review this is to run cargo --doc --open and then looking at
how it is rendered
Oh this is much easier way than I kept doing before, thanks
--
This is an autom
alamb commented on code in PR #14332:
URL: https://github.com/apache/datafusion/pull/14332#discussion_r1934183938
##
datafusion/catalog/src/lib.rs:
##
@@ -15,6 +15,16 @@
// specific language governing permissions and limitations
// under the License.
+//! Interfaces and defa
alamb commented on PR #14332:
URL: https://github.com/apache/datafusion/pull/14332#issuecomment-2622083005
😍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
comphead merged PR #14332:
URL: https://github.com/apache/datafusion/pull/14332
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
comphead commented on PR #14332:
URL: https://github.com/apache/datafusion/pull/14332#issuecomment-2622072090
> if we go with that we should change name of every similar file in a
similar manner (atleast `async.rs`).
That is true, to be consistent it needs to be fixed for all files wh
logan-keede commented on PR #14332:
URL: https://github.com/apache/datafusion/pull/14332#issuecomment-2619670163
> Thanks @logan-keede I'm thinking we should rename `memory.rs` to
`memory_catalog_provider.rs` otherwise its really confusing, I thought
originally its memory pool related crate
logan-keede commented on code in PR #14332:
URL: https://github.com/apache/datafusion/pull/14332#discussion_r1932586533
##
datafusion/catalog/Cargo.toml:
##
@@ -30,10 +30,12 @@ version.workspace = true
[dependencies]
arrow-schema = { workspace = true }
async-trait = { workspa
comphead commented on code in PR #14332:
URL: https://github.com/apache/datafusion/pull/14332#discussion_r1932471120
##
datafusion/catalog/Cargo.toml:
##
@@ -30,10 +30,12 @@ version.workspace = true
[dependencies]
arrow-schema = { workspace = true }
async-trait = { workspace
logan-keede commented on code in PR #14332:
URL: https://github.com/apache/datafusion/pull/14332#discussion_r1931760587
##
datafusion/catalog/src/lib.rs:
##
@@ -15,6 +15,16 @@
// specific language governing permissions and limitations
// under the License.
+//! Interfaces an
logan-keede commented on PR #14332:
URL: https://github.com/apache/datafusion/pull/14332#issuecomment-2618361269
@alamb can this please get a review?
Thanks,
Logan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
logan-keede commented on code in PR #14332:
URL: https://github.com/apache/datafusion/pull/14332#discussion_r1931760587
##
datafusion/catalog/src/lib.rs:
##
@@ -15,6 +15,16 @@
// specific language governing permissions and limitations
// under the License.
+//! Interfaces an
logan-keede opened a new pull request, #14332:
URL: https://github.com/apache/datafusion/pull/14332
## Which issue does this PR close?
Closes part of [#10782](https://github.com/apache/datafusion/issues/10782)
## Rationale for this change
## What changes a
12 matches
Mail list logo
