logan-keede commented on PR #14332: URL: https://github.com/apache/datafusion/pull/14332#issuecomment-2619670163
> Thanks @logan-keede I'm thinking we should rename `memory.rs` to `memory_catalog_provider.rs` otherwise its really confusing, I thought originally its memory pool related crate but it is catalog related. > > WDYT? Welcome, I think `memory_catalog_provider.rs` is too specific given that the same file also covers `MemorySchemaProvider`, given that similar pattern is being followed by almost all the files(look at `async.rs`), we can assume that any developer working on that set of file will notice it too. However, if you think that might cause inefficiency we can go with something like `memory_providers`, again, for consistency's sake if we go with that we should change name of every similar file in a similar manner (atleast `async.rs`). > I am not sure if this is the correct place/way to put this. any idea/comment? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
