alamb commented on code in PR #14555:
URL: https://github.com/apache/datafusion/pull/14555#discussion_r1948945841
##
datafusion/core/Cargo.toml:
##
@@ -43,7 +43,7 @@ array_expressions = ["nested_expressions"]
# Used to enable the avro format
avro = ["apache-avro", "num-traits"
alamb commented on code in PR #14555:
URL: https://github.com/apache/datafusion/pull/14555#discussion_r1948063270
##
datafusion/core/Cargo.toml:
##
@@ -43,7 +43,7 @@ array_expressions = ["nested_expressions"]
# Used to enable the avro format
avro = ["apache-avro", "num-traits"
logan-keede commented on PR #14555:
URL: https://github.com/apache/datafusion/pull/14555#issuecomment-2645932154
> No worries at all - when we merge to main everything in each PR is
squashed into a single commit.
Thanks. I know but still, it feels off.
This is ready for review,
alamb commented on PR #14555:
URL: https://github.com/apache/datafusion/pull/14555#issuecomment-2645872676
> apologies, there were some major fumbles, this should not have taken 11+
commits, I can open a separate PR if this would look too ugly.
No worries at all - when we merge to mai
logan-keede commented on PR #14555:
URL: https://github.com/apache/datafusion/pull/14555#issuecomment-2645871731
apologies, there were some major fumbles, this should not have taken 11+
commits,
I can open a separate PR if this would look too ugly.
--
This is an automated message from
alamb commented on PR #14555:
URL: https://github.com/apache/datafusion/pull/14555#issuecomment-2645741135
> can I get some help with wasm ci? I have hit a wall there.
Looks like that has now been resolved, but there are some other issues that
remain
--
This is an automated message
logan-keede commented on PR #14555:
URL: https://github.com/apache/datafusion/pull/14555#issuecomment-2645589511
cc @alamb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
logan-keede commented on PR #14555:
URL: https://github.com/apache/datafusion/pull/14555#issuecomment-2645220572
can I get some help with wasm ci? I have hit a wall there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
logan-keede opened a new pull request, #14555:
URL: https://github.com/apache/datafusion/pull/14555
## Which issue does this PR close?
- part of https://github.com/apache/datafusion/issues/14462
- Part of https://github.com/apache/datafusion/issues/1.
## Rationale
