alamb commented on code in PR #14555:
URL: https://github.com/apache/datafusion/pull/14555#discussion_r1948063270
##########
datafusion/core/Cargo.toml:
##########
@@ -43,7 +43,7 @@ array_expressions = ["nested_expressions"]
# Used to enable the avro format
avro = ["apache-avro", "num-traits", "datafusion-common/avro"]
backtrace = ["datafusion-common/backtrace"]
-compression = ["xz2", "bzip2", "flate2", "zstd", "async-compression",
"tokio-util"]
+compression = ["xz2", "bzip2", "flate2", "zstd"]
Review Comment:
I am surprised this doesn't need to activate the `compression` feature in
datafusion-catalog-listing as well 🤔
##########
datafusion/sqllogictest/Cargo.toml:
##########
@@ -43,6 +43,7 @@ chrono = { workspace = true, optional = true }
clap = { version = "4.5.16", features = ["derive", "env"] }
datafusion = { workspace = true, default-features = true, features = ["avro"] }
datafusion-catalog = { workspace = true, default-features = true }
+datafusion-catalog-listing = { workspace = true, features = ["compression"] }
Review Comment:
I don't think this should be necessary -- all the required featrues should
be able to be activated via the datafusion crate.
Maybe you can just add `compression` as a feature abovez
```toml
datafusion = { workspace = true, default-features = true, features =
["avro"] }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
