jonahgao merged PR #14213:
URL: https://github.com/apache/datafusion/pull/14213
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
cht42 commented on code in PR #14213:
URL: https://github.com/apache/datafusion/pull/14213#discussion_r1924687592
##
datafusion/sqllogictest/test_files/expr.slt:
##
@@ -465,6 +465,11 @@ SELECT concat_ws('|','a',NULL,NULL)
a
+query T
+SELECT concat_ws('','a','b','c')
Re
cht42 commented on code in PR #14213:
URL: https://github.com/apache/datafusion/pull/14213#discussion_r1924657387
##
datafusion/sqllogictest/test_files/expr.slt:
##
@@ -465,6 +465,11 @@ SELECT concat_ws('|','a',NULL,NULL)
a
+query T
+SELECT concat_ws('','a','b','c')
Re
Omega359 commented on code in PR #14213:
URL: https://github.com/apache/datafusion/pull/14213#discussion_r1924551796
##
datafusion/sqllogictest/test_files/expr.slt:
##
@@ -465,6 +465,11 @@ SELECT concat_ws('|','a',NULL,NULL)
a
+query T
+SELECT concat_ws('','a','b','c')
jonahgao commented on code in PR #14213:
URL: https://github.com/apache/datafusion/pull/14213#discussion_r1923884148
##
datafusion/sqllogictest/test_files/expr.slt:
##
@@ -465,6 +465,11 @@ SELECT concat_ws('|','a',NULL,NULL)
a
+query T
+SELECT concat_ws('','a','b','c')
cht42 commented on code in PR #14213:
URL: https://github.com/apache/datafusion/pull/14213#discussion_r1922736225
##
datafusion/functions/src/string/concat_ws.rs:
##
@@ -317,7 +318,19 @@ fn simplify_concat_ws(delimiter: &Expr, args: &[Expr]) ->
Result
simplify_concat(args.to_v
cht42 opened a new pull request, #14213:
URL: https://github.com/apache/datafusion/pull/14213
## Which issue does this PR close?
Closes #14212
## Rationale for this change
## What changes are included in this PR?
## Are these changes tested?
