jonahgao commented on code in PR #14213:
URL: https://github.com/apache/datafusion/pull/14213#discussion_r1923884148
##########
datafusion/sqllogictest/test_files/expr.slt:
##########
@@ -465,6 +465,11 @@ SELECT concat_ws('|','a',NULL,NULL)
----
a
+query T
+SELECT concat_ws('','a','b','c')
Review Comment:
I tested this query on the
[main](https://github.com/apache/datafusion/commit/2f283277d523404401b206e5b98819a0126341b8)
branch, and it gave the same result. Am I overlooking somethingš¤?
```sh
DataFusion CLI v44.0.0
> SELECT concat_ws('','a','b','c');
+---------------------------------------------------+
| concat_ws(Utf8(""),Utf8("a"),Utf8("b"),Utf8("c")) |
+---------------------------------------------------+
| abc |
+---------------------------------------------------+
1 row(s) fetched.
Elapsed 0.009 seconds.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
