nuno-faria commented on PR #15212:
URL: https://github.com/apache/datafusion/pull/15212#issuecomment-2736367170
Thank you @chenkovsky and @goldmedal for fixing the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
goldmedal merged PR #15212:
URL: https://github.com/apache/datafusion/pull/15212
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@data
goldmedal commented on code in PR #15212:
URL: https://github.com/apache/datafusion/pull/15212#discussion_r1998987034
##
.github/workflows/rust.yml:
##
@@ -246,6 +246,7 @@ jobs:
mc cp -r /source/* localminio/data"
- name: Run tests (excluding doctests)
chenkovsky commented on code in PR #15212:
URL: https://github.com/apache/datafusion/pull/15212#discussion_r1999031362
##
datafusion/sql/src/unparser/expr.rs:
##
@@ -94,6 +94,7 @@ impl Unparser<'_> {
Ok(root_expr)
}
+#[cfg_attr(feature = "recursive_protection
goldmedal commented on code in PR #15212:
URL: https://github.com/apache/datafusion/pull/15212#discussion_r1995622142
##
datafusion/sql/tests/cases/plan_to_sql.rs:
##
@@ -1746,3 +1749,153 @@ fn test_unparse_subquery_alias_with_table_pushdown() ->
Result<()> {
assert_eq!(sq
chenkovsky commented on PR #15212:
URL: https://github.com/apache/datafusion/pull/15212#issuecomment-2725105874
> > for stackoverflow problem. do you have any idea?
>
> No, I don't have any idea currently 🤔. I'm not sure, but I guess
`recursive_protection` is the right direction.
goldmedal commented on PR #15212:
URL: https://github.com/apache/datafusion/pull/15212#issuecomment-2725013843
> for stackoverflow problem. do you have any idea?
No, I don't have any idea currently 🤔. I'm not sure, but I guess
`recursive_protection` is the right direction.
--
This
chenkovsky commented on PR #15212:
URL: https://github.com/apache/datafusion/pull/15212#issuecomment-2724945557
> Thanks @chenkovsky. I think the results of `left mark join`, `right semi
join` and `right anit join` aren't correct (they aren't executable). I left
some comments for them. Coul
chenkovsky commented on PR #15212:
URL: https://github.com/apache/datafusion/pull/15212#issuecomment-2723305518
stackoverflow again. ಥ_ಥ
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
chenkovsky opened a new pull request, #15212:
URL: https://github.com/apache/datafusion/pull/15212
## Which issue does this PR close?
- Closes #15127.
## Rationale for this change
Most SQL dialects don't support specialized join types like LEFT SEMI, LEFT
ANTI, LEFT MARK
10 matches
Mail list logo
