chenkovsky commented on code in PR #15212:
URL: https://github.com/apache/datafusion/pull/15212#discussion_r1999031362
##########
datafusion/sql/src/unparser/expr.rs:
##########
@@ -94,6 +94,7 @@ impl Unparser<'_> {
Ok(root_expr)
}
+ #[cfg_attr(feature = "recursive_protection", recursive::recursive)]
Review Comment:
interesting. actually, I tested in my env, without this annotation, stack
will be overflowed. but with this annotation, it works. so I haven't checked
whether it's enabled in CI. you saved my day.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
