Re: [PR] fix: pass scale to DF round in spark_round [datafusion-comet]

kazuyukitanimura commented on code in PR #1341: URL: https://github.com/apache/datafusion-comet/pull/1341#discussion_r1941886037 ## native/spark-expr/src/math_funcs/round.rs: ## @@ -135,3 +136,50 @@ fn decimal_round_f(scale: &i8, point: &i64) -> Box i128> { Box::new(mov

Re: [PR] fix: pass scale to DF round in spark_round [datafusion-comet]

kazuyukitanimura merged PR #1341: URL: https://github.com/apache/datafusion-comet/pull/1341 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsub

Re: [PR] fix: pass scale to DF round in spark_round [datafusion-comet]

cht42 commented on code in PR #1341: URL: https://github.com/apache/datafusion-comet/pull/1341#discussion_r1941012459 ## native/spark-expr/src/math_funcs/round.rs: ## @@ -135,3 +136,50 @@ fn decimal_round_f(scale: &i8, point: &i64) -> Box i128> { Box::new(move |x: i128|

Re: [PR] fix: pass scale to DF round in spark_round [datafusion-comet]

kazuyukitanimura commented on code in PR #1341: URL: https://github.com/apache/datafusion-comet/pull/1341#discussion_r1934414738 ## native/spark-expr/src/math_funcs/round.rs: ## @@ -135,3 +136,50 @@ fn decimal_round_f(scale: &i8, point: &i64) -> Box i128> { Box::new(mov

Re: [PR] fix: pass scale to DF round in spark_round [datafusion-comet]

cht42 commented on code in PR #1341: URL: https://github.com/apache/datafusion-comet/pull/1341#discussion_r1933876335 ## native/spark-expr/src/math_funcs/round.rs: ## @@ -85,9 +85,10 @@ pub fn spark_round( let (precision, scale) = get_precision_scale(data_type);

Re: [PR] fix: pass scale to DF round in spark_round [datafusion-comet]

kazuyukitanimura commented on code in PR #1341: URL: https://github.com/apache/datafusion-comet/pull/1341#discussion_r1932993113 ## native/spark-expr/src/math_funcs/round.rs: ## @@ -85,9 +85,10 @@ pub fn spark_round( let (precision, scale) = get_precision_scale(

Re: [PR] fix: pass scale to DF round in spark_round [datafusion-comet]

andygrove commented on code in PR #1341: URL: https://github.com/apache/datafusion-comet/pull/1341#discussion_r1932325744 ## native/spark-expr/src/math_funcs/round.rs: ## @@ -85,9 +85,10 @@ pub fn spark_round( let (precision, scale) = get_precision_scale(data_ty

Re: [PR] fix: pass scale to DF round in spark_round [datafusion-comet]

cht42 commented on code in PR #1341: URL: https://github.com/apache/datafusion-comet/pull/1341#discussion_r1931942453 ## native/spark-expr/src/math_funcs/round.rs: ## @@ -85,9 +85,10 @@ pub fn spark_round( let (precision, scale) = get_precision_scale(data_type);

Re: [PR] fix: pass scale to DF round in spark_round [datafusion-comet]

cht42 commented on code in PR #1341: URL: https://github.com/apache/datafusion-comet/pull/1341#discussion_r1931944408 ## native/spark-expr/src/math_funcs/round.rs: ## @@ -85,9 +85,10 @@ pub fn spark_round( let (precision, scale) = get_precision_scale(data_type);

Re: [PR] fix: pass scale to DF round in spark_round [datafusion-comet]

codecov-commenter commented on PR #1341: URL: https://github.com/apache/datafusion-comet/pull/1341#issuecomment-2617022676 ## [Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1341?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca

Re: [PR] fix: pass scale to DF round in spark_round [datafusion-comet]

kazuyukitanimura commented on code in PR #1341: URL: https://github.com/apache/datafusion-comet/pull/1341#discussion_r1931214061 ## native/spark-expr/src/math_funcs/round.rs: ## @@ -85,9 +85,10 @@ pub fn spark_round( let (precision, scale) = get_precision_scale(

[PR] fix: pass scale to DF round in spark_round [datafusion-comet]

cht42 opened a new pull request, #1341: URL: https://github.com/apache/datafusion-comet/pull/1341 ## Which issue does this PR close? Closes #1340. ## Rationale for this change ## What changes are included in this PR? ## How are these changes