cht42 commented on code in PR #1341:
URL: https://github.com/apache/datafusion-comet/pull/1341#discussion_r1931942453
##########
native/spark-expr/src/math_funcs/round.rs:
##########
@@ -85,9 +85,10 @@ pub fn spark_round(
let (precision, scale) = get_precision_scale(data_type);
make_decimal_array(array, precision, scale, &f)
}
- DataType::Float32 | DataType::Float64 => {
- Ok(ColumnarValue::Array(round(&[Arc::clone(array)])?))
- }
+ DataType::Float32 | DataType::Float64 =>
Ok(ColumnarValue::Array(round(&[
Review Comment:
point is being set to the scalar value on this line and we want to pass the
columnar value to DF
```
let ColumnarValue::Scalar(ScalarValue::Int64(Some(point))) = point else
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
