Re: [PR] fix: normalize window ident [datafusion]

2025-04-12 Thread via GitHub
alamb commented on PR #15639: URL: https://github.com/apache/datafusion/pull/15639#issuecomment-2798807532 Thanks @chenkovsky and @comphead -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] fix: normalize window ident [datafusion]

2025-04-12 Thread via GitHub
alamb merged PR #15639: URL: https://github.com/apache/datafusion/pull/15639 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusi

Re: [PR] fix: normalize window ident [datafusion]

2025-04-09 Thread via GitHub
comphead commented on code in PR #15639: URL: https://github.com/apache/datafusion/pull/15639#discussion_r2035690081 ## datafusion/sqllogictest/test_files/window.slt: ## @@ -5610,3 +5610,35 @@ DROP TABLE aggregate_test_100_utf8view; statement ok DROP TABLE aggregate_test_100

Re: [PR] fix: normalize window ident [datafusion]

2025-04-09 Thread via GitHub
chenkovsky commented on code in PR #15639: URL: https://github.com/apache/datafusion/pull/15639#discussion_r2035708094 ## datafusion/sqllogictest/test_files/window.slt: ## @@ -5610,3 +5610,35 @@ DROP TABLE aggregate_test_100_utf8view; statement ok DROP TABLE aggregate_test_1

Re: [PR] fix: normalize window ident [datafusion]

2025-04-09 Thread via GitHub
chenkovsky commented on code in PR #15639: URL: https://github.com/apache/datafusion/pull/15639#discussion_r2035659837 ## datafusion/sql/src/select.rs: ## @@ -914,20 +906,35 @@ fn match_window_definitions( })

Re: [PR] fix: normalize window ident [datafusion]

2025-04-09 Thread via GitHub
comphead commented on code in PR #15639: URL: https://github.com/apache/datafusion/pull/15639#discussion_r2035688286 ## datafusion/sql/src/select.rs: ## @@ -914,20 +906,35 @@ fn match_window_definitions( }) }

Re: [PR] fix: normalize window ident [datafusion]

2025-04-09 Thread via GitHub
comphead commented on code in PR #15639: URL: https://github.com/apache/datafusion/pull/15639#discussion_r2035594591 ## datafusion/sql/src/select.rs: ## @@ -914,20 +906,35 @@ fn match_window_definitions( }) }

[PR] fix: normalize window ident [datafusion]

2025-04-08 Thread via GitHub
chenkovsky opened a new pull request, #15639: URL: https://github.com/apache/datafusion/pull/15639 ## Which issue does this PR close? - Closes #15605. ## Rationale for this change ident normalizer is not called. ## What changes are included in this PR? norma