comphead commented on code in PR #15639:
URL: https://github.com/apache/datafusion/pull/15639#discussion_r2035688286
##########
datafusion/sql/src/select.rs:
##########
@@ -914,20 +906,35 @@ fn match_window_definitions(
})
}
}
- }
- // All named windows must be defined with a WindowSpec.
- if let Some(WindowType::NamedWindow(ident)) = &f.over {
- err = Some(DataFusionError::Plan(format!(
- "The window {ident} is not defined!"
- )));
- return ControlFlow::Break(());
+ // All named windows must be defined with a
WindowSpec.
+ if let Some(WindowType::NamedWindow(ident)) =
&f.over {
+ err = Some(DataFusionError::Plan(format!(
Review Comment:
@chenkovsky can you make a favor and change this to `plan_err!`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
