Re: [PR] fix: fall back on nested types for default values [datafusion-comet]

2025-05-28 Thread via GitHub
andygrove merged PR #1799: URL: https://github.com/apache/datafusion-comet/pull/1799 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@

Re: [PR] fix: fall back on nested types for default values [datafusion-comet]

2025-05-28 Thread via GitHub
mbutrovich commented on code in PR #1799: URL: https://github.com/apache/datafusion-comet/pull/1799#discussion_r2112261140 ## spark/src/main/scala/org/apache/comet/rules/CometScanRule.scala: ## @@ -118,7 +119,17 @@ case class CometScanRule(session: SparkSession) extends Rule[Sp

Re: [PR] fix: fall back on nested types for default values [datafusion-comet]

2025-05-28 Thread via GitHub
comphead commented on code in PR #1799: URL: https://github.com/apache/datafusion-comet/pull/1799#discussion_r2112239658 ## spark/src/main/scala/org/apache/comet/rules/CometScanRule.scala: ## @@ -118,7 +119,17 @@ case class CometScanRule(session: SparkSession) extends Rule[Spar

Re: [PR] fix: fall back on nested types for default values [datafusion-comet]

2025-05-28 Thread via GitHub
mbutrovich commented on code in PR #1799: URL: https://github.com/apache/datafusion-comet/pull/1799#discussion_r2111696963 ## spark/src/main/scala/org/apache/comet/rules/CometScanRule.scala: ## @@ -118,7 +119,17 @@ case class CometScanRule(session: SparkSession) extends Rule[Sp

Re: [PR] fix: fall back on nested types for default values [datafusion-comet]

2025-05-27 Thread via GitHub
parthchandra commented on code in PR #1799: URL: https://github.com/apache/datafusion-comet/pull/1799#discussion_r2110391732 ## spark/src/main/scala/org/apache/comet/rules/CometScanRule.scala: ## @@ -118,7 +119,17 @@ case class CometScanRule(session: SparkSession) extends Rule[

Re: [PR] fix: fall back on nested types for default values [datafusion-comet]

2025-05-27 Thread via GitHub
codecov-commenter commented on PR #1799: URL: https://github.com/apache/datafusion-comet/pull/1799#issuecomment-2913996011 ## [Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1799?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca

Re: [PR] fix: fall back on nested types for default values [datafusion-comet]

2025-05-27 Thread via GitHub
andygrove commented on code in PR #1799: URL: https://github.com/apache/datafusion-comet/pull/1799#discussion_r2109498280 ## spark/src/main/scala/org/apache/comet/rules/CometScanRule.scala: ## @@ -118,7 +119,18 @@ case class CometScanRule(session: SparkSession) extends Rule[Spa

Re: [PR] fix: fall back on nested types for default values [datafusion-comet]

2025-05-27 Thread via GitHub
mbutrovich commented on PR #1799: URL: https://github.com/apache/datafusion-comet/pull/1799#issuecomment-2912986358 I'll update the compatibility guide as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] fix: fall back on nested types for default values [datafusion-comet]

2025-05-27 Thread via GitHub
mbutrovich opened a new pull request, #1799: URL: https://github.com/apache/datafusion-comet/pull/1799 ## Which issue does this PR close? Partially address #1545. ## Rationale for this change #1756 added default value support for native_datafusion scan. Ho