comphead commented on code in PR #1799:
URL: https://github.com/apache/datafusion-comet/pull/1799#discussion_r2112239658
##########
spark/src/main/scala/org/apache/comet/rules/CometScanRule.scala:
##########
@@ -118,7 +119,17 @@ case class CometScanRule(session: SparkSession) extends
Rule[SparkPlan] {
return withInfos(scanExec, fallbackReasons.toSet)
}
- val typeChecker = new CometScanTypeChecker(scanImpl)
+ val possibleDefaultValues =
getExistenceDefaultValues(scanExec.requiredSchema)
+ if (possibleDefaultValues.exists(d => {
+ d != null && (d.isInstanceOf[ArrayBasedMapData] || d
+ .isInstanceOf[GenericInternalRow] ||
d.isInstanceOf[GenericArrayData])
Review Comment:
It is nice to have a comment that...
`GenericInternalRow` probably represents `StructType` here but this is not
so obvious, wondering if that would be possible to do this check in terms of
SQL types? `StructType`, `ArrayType`, `MapType` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
