codecov-commenter commented on PR #1756:
URL:
https://github.com/apache/datafusion-comet/pull/1756#issuecomment-2897811173
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1756?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
mbutrovich commented on PR #1756:
URL:
https://github.com/apache/datafusion-comet/pull/1756#issuecomment-2897762420
Something else to look at for Spark 3.4...
```
select column with default value (native_comet, native shuffle) *** FAILED
*** (449 milliseconds)
org.apache.spark.sq
mbutrovich commented on PR #1756:
URL:
https://github.com/apache/datafusion-comet/pull/1756#issuecomment-2897657612
I accidentally pushed the int96 docs changes to the wrong branch :(
I'll just leave it here since CI is already running.
--
This is an automated message from the Apac
mbutrovich commented on code in PR #1756:
URL: https://github.com/apache/datafusion-comet/pull/1756#discussion_r2098980947
##
native/core/src/execution/planner.rs:
##
@@ -1108,6 +1108,44 @@ impl PhysicalPlanner {
.map(|expr| self.create_expr(expr,
Arc::clon
andygrove commented on code in PR #1756:
URL: https://github.com/apache/datafusion-comet/pull/1756#discussion_r2098863135
##
native/core/src/execution/planner.rs:
##
@@ -1108,6 +1108,44 @@ impl PhysicalPlanner {
.map(|expr| self.create_expr(expr,
Arc::clone
mbutrovich commented on code in PR #1756:
URL: https://github.com/apache/datafusion-comet/pull/1756#discussion_r2098534086
##
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##
@@ -2327,18 +2346,18 @@ object QueryPlanSerde extends Logging with
CometExprShim {
mbutrovich commented on code in PR #1756:
URL: https://github.com/apache/datafusion-comet/pull/1756#discussion_r2098532793
##
spark/src/test/scala/org/apache/comet/CometFuzzTestSuite.scala:
##
@@ -99,6 +100,56 @@ class CometFuzzTestSuite extends CometTestBase with
AdaptiveSpark
andygrove commented on code in PR #1756:
URL: https://github.com/apache/datafusion-comet/pull/1756#discussion_r2098530916
##
spark/src/test/scala/org/apache/comet/CometFuzzTestSuite.scala:
##
@@ -99,6 +100,56 @@ class CometFuzzTestSuite extends CometTestBase with
AdaptiveSparkP
mbutrovich commented on code in PR #1756:
URL: https://github.com/apache/datafusion-comet/pull/1756#discussion_r2098530199
##
native/core/src/parquet/schema_adapter.rs:
##
@@ -196,15 +198,43 @@ impl SchemaMapper for SchemaMapping {
// go through each field in the pr
mbutrovich commented on code in PR #1756:
URL: https://github.com/apache/datafusion-comet/pull/1756#discussion_r2098529235
##
native/core/src/parquet/parquet_support.rs:
##
@@ -60,9 +60,6 @@ pub struct SparkParquetOptions {
pub allow_incompat: bool,
/// Support casting
mbutrovich commented on code in PR #1756:
URL: https://github.com/apache/datafusion-comet/pull/1756#discussion_r2098527578
##
native/core/src/parquet/mod.rs:
##
@@ -715,6 +715,7 @@ pub unsafe extern "system" fn
Java_org_apache_comet_parquet_Native_initRecordBat
fil
mbutrovich commented on code in PR #1756:
URL: https://github.com/apache/datafusion-comet/pull/1756#discussion_r2098528439
##
native/core/src/parquet/parquet_exec.rs:
##
@@ -61,12 +63,14 @@ pub(crate) fn init_datasource_exec(
file_groups: Vec>,
projection_vector: Optio
12 matches
Mail list logo
