mbutrovich commented on code in PR #1756:
URL: https://github.com/apache/datafusion-comet/pull/1756#discussion_r2098528439
##########
native/core/src/parquet/parquet_exec.rs:
##########
@@ -61,12 +63,14 @@ pub(crate) fn init_datasource_exec(
file_groups: Vec<Vec<PartitionedFile>>,
projection_vector: Option<Vec<usize>>,
data_filters: Option<Vec<Arc<dyn PhysicalExpr>>>,
+ default_values: Option<HashMap<usize, ScalarValue>>,
session_timezone: &str,
) -> Result<Arc<DataSourceExec>, ExecutionError> {
let (table_parquet_options, spark_parquet_options) =
get_options(session_timezone);
- let mut parquet_source =
ParquetSource::new(table_parquet_options).with_schema_adapter_factory(
- Arc::new(SparkSchemaAdapterFactory::new(spark_parquet_options)),
- );
+ let mut parquet_source =
+
ParquetSource::new(table_parquet_options).with_schema_adapter_factory(Arc::new(
+ SparkSchemaAdapterFactory::new(spark_parquet_options,
default_values),
Review Comment:
We can discuss if it makes more sense to stick `default_values` inside of
the `SparkParquetOptions` struct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
