Re: [PR] fix: Assertion fail in external sort [datafusion]

2025-03-30 Thread via GitHub
2010YOUY01 commented on code in PR #15469: URL: https://github.com/apache/datafusion/pull/15469#discussion_r2020384227 ## datafusion/physical-plan/src/sorts/sort.rs: ## @@ -216,10 +216,8 @@ struct ExternalSorter { // STATE BUFFERS: // Fields that hold intermediate data

Re: [PR] fix: Assertion fail in external sort [datafusion]

2025-03-30 Thread via GitHub
comphead merged PR #15469: URL: https://github.com/apache/datafusion/pull/15469 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@dataf

Re: [PR] fix: Assertion fail in external sort [datafusion]

2025-03-30 Thread via GitHub
alamb commented on code in PR #15469: URL: https://github.com/apache/datafusion/pull/15469#discussion_r2020125627 ## datafusion/physical-plan/src/sorts/sort.rs: ## @@ -397,16 +393,13 @@ impl ExternalSorter { self.metrics.spill_metrics.spill_file_count.value() } -

Re: [PR] fix: Assertion fail in external sort [datafusion]

2025-03-29 Thread via GitHub
2010YOUY01 commented on code in PR #15469: URL: https://github.com/apache/datafusion/pull/15469#discussion_r2020058583 ## datafusion/physical-plan/src/sorts/sort.rs: ## @@ -416,21 +409,23 @@ impl ExternalSorter { Some(self.spill_manager.create_in_progress_file("

Re: [PR] fix: Assertion fail in external sort [datafusion]

2025-03-28 Thread via GitHub
comphead commented on code in PR #15469: URL: https://github.com/apache/datafusion/pull/15469#discussion_r2019237566 ## datafusion/physical-plan/src/sorts/sort.rs: ## @@ -416,21 +409,23 @@ impl ExternalSorter { Some(self.spill_manager.create_in_progress_file("So

Re: [PR] fix: Assertion fail in external sort [datafusion]

2025-03-28 Thread via GitHub
Copilot commented on code in PR #15469: URL: https://github.com/apache/datafusion/pull/15469#discussion_r2018081822 ## datafusion/physical-plan/src/sorts/sort.rs: ## @@ -416,21 +409,23 @@ impl ExternalSorter { Some(self.spill_manager.create_in_progress_file("Sor

[PR] fix: Assertion fail in external sort [datafusion]

2025-03-28 Thread via GitHub
2010YOUY01 opened a new pull request, #15469: URL: https://github.com/apache/datafusion/pull/15469 ## Which issue does this PR close? related to https://github.com/apache/datafusion/issues/15372 ## Rationale for this change One external sort query will panic d