comphead commented on code in PR #15469:
URL: https://github.com/apache/datafusion/pull/15469#discussion_r2019237566
##########
datafusion/physical-plan/src/sorts/sort.rs:
##########
@@ -416,21 +409,23 @@ impl ExternalSorter {
Some(self.spill_manager.create_in_progress_file("Sorting")?);
}
- self.organize_stringview_arrays()?;
+ Self::organize_stringview_arrays(globally_sorted_batches)?;
debug!("Spilling sort data of ExternalSorter to disk whilst
inserting");
- let batches = std::mem::take(&mut self.in_mem_batches);
+ let batches_to_spill = std::mem::take(globally_sorted_batches);
self.reservation.free();
let in_progress_file =
self.in_progress_spill_file.as_mut().ok_or_else(|| {
internal_datafusion_err!("In-progress spill file should be
initialized")
})?;
- for batch in batches {
+ for batch in batches_to_spill {
in_progress_file.append_batch(&batch)?;
}
+ assert!(globally_sorted_batches.is_empty());
Review Comment:
perhaps we can get rid of assert and return `Err`? if the code regressed the
users can face the app crash
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
