chenkovsky commented on PR #16505:
URL: https://github.com/apache/datafusion/pull/16505#issuecomment-3004038741
some comments were added in cargo file today.
https://github.com/apache/datafusion/blob/20a723b7b6d91da57fe6abea8ecac08ea5267a89/datafusion/sql/Cargo.toml#L49
.
it makes s
chenkovsky commented on PR #16505:
URL: https://github.com/apache/datafusion/pull/16505#issuecomment-3003924958
> @2010YOUY01 thank you for pointing this out.
>
> @chenkovsky, it looks like both our PRs solve the same sampling problem
from different approaches. The direction of my PR
theirix commented on PR #16505:
URL: https://github.com/apache/datafusion/pull/16505#issuecomment-3003701483
@2010YOUY01 thank you for pointing this out.
@chenkovsky, it looks like both our PRs solve the same sampling problem from
different approaches. The direction of my PR is to con
chenkovsky commented on PR #16505:
URL: https://github.com/apache/datafusion/pull/16505#issuecomment-2999488349
> I suggest to first open an issue to describe full syntax and semantics of
this table sample feature, and also include the reference system (like
postgres). After we have reached
2010YOUY01 commented on PR #16505:
URL: https://github.com/apache/datafusion/pull/16505#issuecomment-2999386422
I suggest to first open an issue to describe full syntax and semantics of
this table sample feature, and also include the reference system (like
postgres). After we have reached s
chenkovsky commented on PR #16505:
URL: https://github.com/apache/datafusion/pull/16505#issuecomment-2996411604
> It would be better to add more details about the PR, such as: sample
levels: block level or row level sample ways: fixed row counts or percent?
@xudong963 updated
--
T
xudong963 commented on PR #16505:
URL: https://github.com/apache/datafusion/pull/16505#issuecomment-2996237484
It would be better to add more details about the PR, such as:
sample levels: block level or row level
sample ways: fixed row counts or percent?
--
This is an automated messa
