chenkovsky commented on PR #16505: URL: https://github.com/apache/datafusion/pull/16505#issuecomment-2999488349
> I suggest to first open an issue to describe full syntax and semantics of this table sample feature, and also include the reference system (like postgres). After we have reached some agreement, then we can start implementing. > > There is another implementation that seems to have several syntax difference than this PR #16325 @theirix > > We had a previous discussion that DF can include features for postgres syntax. However if it's referencing other systems, then it might need more discussion and wider approval. Updated, and this PR implements Spark style sample. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
