chenkovsky commented on code in PR #15667:
URL: https://github.com/apache/datafusion/pull/15667#discussion_r2097992883
##
datafusion/functions-aggregate/src/min_max.rs:
##
@@ -619,6 +625,45 @@ fn min_batch(values: &ArrayRef) -> Result {
})
}
+fn min_max_batch_struct(arra
alamb merged PR #15667:
URL: https://github.com/apache/datafusion/pull/15667
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
chenkovsky commented on code in PR #15667:
URL: https://github.com/apache/datafusion/pull/15667#discussion_r2072519832
##
datafusion/functions-aggregate/src/min_max.rs:
##
@@ -619,6 +625,45 @@ fn min_batch(values: &ArrayRef) -> Result {
})
}
+fn min_max_batch_struct(arra
chenkovsky commented on code in PR #15667:
URL: https://github.com/apache/datafusion/pull/15667#discussion_r2072517249
##
datafusion/functions-aggregate/src/min_max.rs:
##
@@ -619,6 +625,45 @@ fn min_batch(values: &ArrayRef) -> Result {
})
}
+fn min_max_batch_struct(arra
alamb commented on code in PR #15667:
URL: https://github.com/apache/datafusion/pull/15667#discussion_r2072364948
##
datafusion/functions-aggregate-common/src/aggregate/groups_accumulator/nulls.rs:
##
@@ -193,6 +193,14 @@ pub fn set_nulls_dyn(input: &dyn Array, nulls:
Option) -
chenkovsky commented on PR #15667:
URL: https://github.com/apache/datafusion/pull/15667#issuecomment-2837583800
@alamb could you please review it again ? I see min/max for dict is
supported now. struct is similar.
--
This is an automated message from the Apache Git Service.
To respond to
chenkovsky commented on code in PR #15667:
URL: https://github.com/apache/datafusion/pull/15667#discussion_r2042084363
##
datafusion/functions-aggregate/src/min_max.rs:
##
@@ -610,10 +611,57 @@ fn min_batch(values: &ArrayRef) -> Result {
min_binary_view
alamb commented on code in PR #15667:
URL: https://github.com/apache/datafusion/pull/15667#discussion_r2037994858
##
datafusion/functions-aggregate/src/min_max.rs:
##
@@ -610,10 +611,57 @@ fn min_batch(values: &ArrayRef) -> Result {
min_binary_view
alamb commented on PR #15667:
URL: https://github.com/apache/datafusion/pull/15667#issuecomment-2794741953
> the performance for struct is worse than primitive types. does anyone have
suggestions about optimizing it.
Do make it faster you could implement a `GroupsAccumulator`
--
Th
chenkovsky opened a new pull request, #15667:
URL: https://github.com/apache/datafusion/pull/15667
## Which issue does this PR close?
- Closes #15666.
## Rationale for this change
datafusion doesn't support min/max for struct.
## What changes are included in this P
10 matches
Mail list logo
