alamb commented on code in PR #15667:
URL: https://github.com/apache/datafusion/pull/15667#discussion_r2037994858
##########
datafusion/functions-aggregate/src/min_max.rs:
##########
@@ -610,10 +611,57 @@ fn min_batch(values: &ArrayRef) -> Result<ScalarValue> {
min_binary_view
)
}
+ DataType::Struct(_) => min_max_batch_struct(values,
Ordering::Greater)?,
_ => min_max_batch!(values, min),
})
}
+fn min_max_batch_struct(array: &ArrayRef, ordering: Ordering) ->
Result<ScalarValue> {
Review Comment:
What definition of "greater / less than" does this use? I think figuring out
how to compare structs (like what does it mean for one struct to be bigger than
the other) was not clear
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
