Re: [PR] feat: rand expression support [datafusion-comet]

2025-06-25 Thread via GitHub
andygrove merged PR #1199: URL: https://github.com/apache/datafusion-comet/pull/1199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@

Re: [PR] feat: rand expression support [datafusion-comet]

2025-06-25 Thread via GitHub
andygrove commented on code in PR #1199: URL: https://github.com/apache/datafusion-comet/pull/1199#discussion_r2164560751 ## spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala: ## @@ -2806,6 +2806,26 @@ class CometExpressionSuite extends CometTestBase with Adaptiv

Re: [PR] feat: rand expression support [datafusion-comet]

2025-06-24 Thread via GitHub
andygrove commented on code in PR #1199: URL: https://github.com/apache/datafusion-comet/pull/1199#discussion_r2164559552 ## spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala: ## @@ -2806,6 +2806,26 @@ class CometExpressionSuite extends CometTestBase with Adaptiv

Re: [PR] feat: rand expression support [datafusion-comet]

2025-06-24 Thread via GitHub
andygrove commented on code in PR #1199: URL: https://github.com/apache/datafusion-comet/pull/1199#discussion_r2164642169 ## spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala: ## @@ -2806,6 +2806,26 @@ class CometExpressionSuite extends CometTestBase with Adaptiv

Re: [PR] feat: rand expression support [datafusion-comet]

2025-06-24 Thread via GitHub
andygrove commented on PR #1199: URL: https://github.com/apache/datafusion-comet/pull/1199#issuecomment-3001227976 I upmerged this PR and re-triggered the workflows. Sorry for the delay @akupchinskiy -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] feat: rand expression support [datafusion-comet]

2025-03-15 Thread via GitHub
akupchinskiy commented on PR #1199: URL: https://github.com/apache/datafusion-comet/pull/1199#issuecomment-2706942272 @kazuyukitanimura could you trigger the workflow? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] feat: rand expression support [datafusion-comet]

2025-03-15 Thread via GitHub
akupchinskiy commented on PR #1199: URL: https://github.com/apache/datafusion-comet/pull/1199#issuecomment-2704600195 > @akupchinskiy do you plan to resolve the conflicts? Yeah, thanks for the reminder. Will do it tomorrow -- This is an automated message from the Apache Git Service

Re: [PR] feat: rand expression support [datafusion-comet]

2025-03-05 Thread via GitHub
kazuyukitanimura commented on PR #1199: URL: https://github.com/apache/datafusion-comet/pull/1199#issuecomment-2702519134 @akupchinskiy do you plan to resolve the conflicts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] feat: rand expression support [datafusion-comet]

2025-01-16 Thread via GitHub
akupchinskiy commented on code in PR #1199: URL: https://github.com/apache/datafusion-comet/pull/1199#discussion_r1919630965 ## native/core/src/execution/jni_api.rs: ## @@ -317,7 +317,7 @@ pub unsafe extern "system" fn Java_org_apache_comet_Native_executePlan( // query

Re: [PR] feat: rand expression support [datafusion-comet]

2025-01-10 Thread via GitHub
andygrove commented on code in PR #1199: URL: https://github.com/apache/datafusion-comet/pull/1199#discussion_r1910483116 ## native/core/src/execution/jni_api.rs: ## @@ -317,7 +317,7 @@ pub unsafe extern "system" fn Java_org_apache_comet_Native_executePlan( // query pl

Re: [PR] feat: rand expression support [datafusion-comet]

2025-01-05 Thread via GitHub
rluvaton commented on code in PR #1199: URL: https://github.com/apache/datafusion-comet/pull/1199#discussion_r1903241784 ## native/spark-expr/src/rand.rs: ## @@ -0,0 +1,272 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreemen

Re: [PR] feat: rand expression support [datafusion-comet]

2025-01-05 Thread via GitHub
akupchinskiy commented on code in PR #1199: URL: https://github.com/apache/datafusion-comet/pull/1199#discussion_r1903226083 ## native/spark-expr/src/rand.rs: ## @@ -0,0 +1,261 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agre

Re: [PR] feat: rand expression support [datafusion-comet]

2025-01-05 Thread via GitHub
akupchinskiy commented on code in PR #1199: URL: https://github.com/apache/datafusion-comet/pull/1199#discussion_r1903227347 ## native/core/src/execution/jni_api.rs: ## @@ -317,7 +317,7 @@ pub unsafe extern "system" fn Java_org_apache_comet_Native_executePlan( // query

Re: [PR] feat: rand expression support [datafusion-comet]

2025-01-05 Thread via GitHub
akupchinskiy commented on PR #1199: URL: https://github.com/apache/datafusion-comet/pull/1199#issuecomment-2571552288 > Are the partition related changes necessary for this PR? Otherwise, it might be better to reduce the scope to just the `rand()` expression. There is a handful of ex

Re: [PR] feat: rand expression support [datafusion-comet]

2025-01-05 Thread via GitHub
akupchinskiy commented on code in PR #1199: URL: https://github.com/apache/datafusion-comet/pull/1199#discussion_r1903222710 ## native/spark-expr/src/rand.rs: ## @@ -0,0 +1,261 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agre

Re: [PR] feat: rand expression support [datafusion-comet]

2025-01-02 Thread via GitHub
comphead commented on code in PR #1199: URL: https://github.com/apache/datafusion-comet/pull/1199#discussion_r1901255361 ## native/core/src/execution/jni_api.rs: ## @@ -317,7 +317,7 @@ pub unsafe extern "system" fn Java_org_apache_comet_Native_executePlan( // query pla

Re: [PR] feat: rand expression support [datafusion-comet]

2025-01-02 Thread via GitHub
dharanad commented on code in PR #1199: URL: https://github.com/apache/datafusion-comet/pull/1199#discussion_r1901024382 ## native/spark-expr/src/rand.rs: ## @@ -0,0 +1,261 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreemen

Re: [PR] feat: rand expression support [datafusion-comet]

2025-01-02 Thread via GitHub
dharanad commented on code in PR #1199: URL: https://github.com/apache/datafusion-comet/pull/1199#discussion_r1901022547 ## native/spark-expr/src/rand.rs: ## @@ -0,0 +1,261 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreemen

Re: [PR] feat: rand expression support [datafusion-comet]

2025-01-02 Thread via GitHub
mbutrovich commented on PR #1199: URL: https://github.com/apache/datafusion-comet/pull/1199#issuecomment-2567981055 Are the partition related changes necessary for this PR? Otherwise, it might be better to reduce the scope to just the `rand()` expression. -- This is an automated message

Re: [PR] feat: rand expression support [datafusion-comet]

2024-12-29 Thread via GitHub
andygrove commented on PR #1199: URL: https://github.com/apache/datafusion-comet/pull/1199#issuecomment-2564989612 Thanks @akupchinskiy. I plan on reviewing this after the holidays. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] feat: rand expression support [datafusion-comet]

2024-12-27 Thread via GitHub
codecov-commenter commented on PR #1199: URL: https://github.com/apache/datafusion-comet/pull/1199#issuecomment-2564234382 ## [Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1199?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca

[PR] feat: rand expression support [datafusion-comet]

2024-12-24 Thread via GitHub
akupchinskiy opened a new pull request, #1199: URL: https://github.com/apache/datafusion-comet/pull/1199 ## Which issue does this PR close? Closes [#1198](https://github.com/apache/datafusion-comet/issues/1198) ## Rationale for this change Support of the spark