andygrove commented on code in PR #1199:
URL: https://github.com/apache/datafusion-comet/pull/1199#discussion_r1910483116


##########
native/core/src/execution/jni_api.rs:
##########
@@ -317,7 +317,7 @@ pub unsafe extern "system" fn 
Java_org_apache_comet_Native_executePlan(
         // query plan, we need to defer stream initialization to first time 
execution.
         if exec_context.root_op.is_none() {
             let start = Instant::now();
-            let planner = 
PhysicalPlanner::new(Arc::clone(&exec_context.session_ctx))
+            let planner = 
PhysicalPlanner::new(Arc::clone(&exec_context.session_ctx), partition)

Review Comment:
   This is something that I would like to see improved. We currently use 
partition 0 for each native plan rather than the real partition id.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to