alamb commented on code in PR #16161:
URL: https://github.com/apache/datafusion/pull/16161#discussion_r2164876290
##
datafusion/sql/Cargo.toml:
##
@@ -48,6 +48,7 @@ arrow = { workspace = true }
bigdecimal = { workspace = true }
datafusion-common = { workspace = true, default-f
eejbyfeldt commented on PR #16161:
URL: https://github.com/apache/datafusion/pull/16161#issuecomment-2981365745
I did not look closely at yet since I have not really contributed here in
months.
> there are three projections. for bitwise operation, there's no benifit for
extra projec
chenkovsky commented on PR #16161:
URL: https://github.com/apache/datafusion/pull/16161#issuecomment-2906804315
it's related to #12704
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
chenkovsky commented on PR #16161:
URL: https://github.com/apache/datafusion/pull/16161#issuecomment-2906801006
@eejbyfeldt could you please help me review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
alamb commented on PR #16161:
URL: https://github.com/apache/datafusion/pull/16161#issuecomment-2906786682
Thanks @chenkovsky -- can. you find the original PR that added this
`GROUPING` function and perhaps @ mention the author to see if they have any
feedback / could help with review?
-
chenkovsky opened a new pull request, #16161:
URL: https://github.com/apache/datafusion/pull/16161
## Which issue does this PR close?
## Rationale for this change
first, it seems that grouping udaf document is not correct.
and for aggregation with grouping,
e.g
