eejbyfeldt commented on PR #16161: URL: https://github.com/apache/datafusion/pull/16161#issuecomment-2981365745
I did not look closely at yet since I have not really contributed here in months. > there are three projections. for bitwise operation, there's no benifit for extra projection. This extra projection is introduced by `CommonSubexprEliminate`. I understand that the changes make it so that they do not interact in the presented query, but is this really a general fix of that behavior? But the goal of leaving more structure in logical plan after resolving the grouping expr so that optimization and unparsing sounds reasonable to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
