alamb commented on PR #15311:
URL: https://github.com/apache/datafusion/pull/15311#issuecomment-2740937315
Thanks @westhide
For anyone following along:
- https://github.com/apache/datafusion/pull/15335
--
This is an automated message from the Apache Git Service.
To respond to t
alamb merged PR #15311:
URL: https://github.com/apache/datafusion/pull/15311
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
westhide commented on code in PR #15311:
URL: https://github.com/apache/datafusion/pull/15311#discussion_r2005735108
##
datafusion/proto/src/physical_plan/mod.rs:
##
@@ -247,6 +247,15 @@ impl AsExecutionPlan for protobuf::PhysicalPlanNode {
.with_file_compressio
milenkovicm commented on code in PR #15311:
URL: https://github.com/apache/datafusion/pull/15311#discussion_r2005232310
##
datafusion/proto/src/physical_plan/mod.rs:
##
@@ -247,6 +247,15 @@ impl AsExecutionPlan for protobuf::PhysicalPlanNode {
.with_file_compres
westhide commented on code in PR #15311:
URL: https://github.com/apache/datafusion/pull/15311#discussion_r2004474014
##
datafusion/proto/src/physical_plan/mod.rs:
##
@@ -247,6 +247,15 @@ impl AsExecutionPlan for protobuf::PhysicalPlanNode {
.with_file_compressio
westhide commented on code in PR #15311:
URL: https://github.com/apache/datafusion/pull/15311#discussion_r2004474014
##
datafusion/proto/src/physical_plan/mod.rs:
##
@@ -247,6 +247,15 @@ impl AsExecutionPlan for protobuf::PhysicalPlanNode {
.with_file_compressio
milenkovicm commented on PR #15311:
URL: https://github.com/apache/datafusion/pull/15311#issuecomment-2738095787
Thanks @westhide, PR makes sense to me.
I left one comment in the original ballista issue,
https://github.com/apache/datafusion-ballista/issues/1209#issuecomment-273746633
alamb commented on code in PR #15311:
URL: https://github.com/apache/datafusion/pull/15311#discussion_r2004114810
##
datafusion/proto/tests/cases/roundtrip_physical_plan.rs:
##
@@ -1277,6 +1277,15 @@ fn roundtrip_analyze() -> Result<()> {
)))
}
+#[tokio::test]
+async fn
westhide commented on PR #15311:
URL: https://github.com/apache/datafusion/pull/15311#issuecomment-2737288323
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
westhide opened a new pull request, #15311:
URL: https://github.com/apache/datafusion/pull/15311
## Which issue does this PR close?
- Closes #.
## Rationale for this change
## What changes are included in this PR?
## Are these changes tested
10 matches
Mail list logo
