alamb commented on code in PR #15311:
URL: https://github.com/apache/datafusion/pull/15311#discussion_r2004114810
##########
datafusion/proto/tests/cases/roundtrip_physical_plan.rs:
##########
@@ -1277,6 +1277,15 @@ fn roundtrip_analyze() -> Result<()> {
)))
}
+#[tokio::test]
+async fn roundtrip_json_source() -> Result<()> {
+ let ctx = SessionContext::new();
+ ctx.register_json("t1", "../core/tests/data/1.json", Default::default())
+ .await?;
+ let plan = ctx.table("t1").await?.create_physical_plan().await?;
Review Comment:
👍
##########
datafusion/proto/src/physical_plan/mod.rs:
##########
@@ -247,6 +247,15 @@ impl AsExecutionPlan for protobuf::PhysicalPlanNode {
.with_file_compression_type(FileCompressionType::UNCOMPRESSED);
Ok(conf.build())
}
+ PhysicalPlanType::JsonScan(scan) => {
Review Comment:
It seems like there is one more relevant field for JsonSource, `batch_size`
https://github.com/apache/datafusion/blob/6d5e00ad3f8e53f7252cb1d3c72a6c7f28c1aed6/datafusion/datasource-json/src/source.rs#L251-L257
Perhaps we can add that field to the serialization as well (or file a ticket
to add it?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
