Re: [PR] feat: Support hadoop s3a config in native_iceberg_compat [datafusion-comet]

2025-06-24 Thread via GitHub
parthchandra merged PR #1925: URL: https://github.com/apache/datafusion-comet/pull/1925 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr.

Re: [PR] feat: Support hadoop s3a config in native_iceberg_compat [datafusion-comet]

2025-06-24 Thread via GitHub
andygrove commented on code in PR #1925: URL: https://github.com/apache/datafusion-comet/pull/1925#discussion_r2164542993 ## native/core/src/parquet/mod.rs: ## @@ -644,6 +647,26 @@ fn get_file_groups_single_file( vec![groups] } +pub fn get_object_store_options( +env:

Re: [PR] feat: Support hadoop s3a config in native_iceberg_compat [datafusion-comet]

2025-06-24 Thread via GitHub
parthchandra commented on PR #1925: URL: https://github.com/apache/datafusion-comet/pull/1925#issuecomment-3001134902 > I have tested it with AWS S3 and it worked fine Thank you! I managed to test it with S3 as well. -- This is an automated message from the Apache Git Service. To

Re: [PR] feat: Support hadoop s3a config in native_iceberg_compat [datafusion-comet]

2025-06-23 Thread via GitHub
codecov-commenter commented on PR #1925: URL: https://github.com/apache/datafusion-comet/pull/1925#issuecomment-2998365766 ## [Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1925?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca

Re: [PR] feat: Support hadoop s3a config in native_iceberg_compat [datafusion-comet]

2025-06-23 Thread via GitHub
parthchandra commented on PR #1925: URL: https://github.com/apache/datafusion-comet/pull/1925#issuecomment-2998299473 @Kontinuation please review if you can. (This PR is draft because I haven't been able to test it with S3 yet. The unit test passes, though). -- This is an automated me

[PR] feat: Support hadoop s3a config in native_iceberg_compat [datafusion-comet]

2025-06-23 Thread via GitHub
parthchandra opened a new pull request, #1925: URL: https://github.com/apache/datafusion-comet/pull/1925 #1817 introduced S3A configuration for the `native_datafusion` reader. This PR does the same for `native_iceberg_compat` ## How are these changes tested? Existing unit t