andygrove commented on code in PR #1925:
URL: https://github.com/apache/datafusion-comet/pull/1925#discussion_r2164542993
##########
native/core/src/parquet/mod.rs:
##########
@@ -644,6 +647,26 @@ fn get_file_groups_single_file(
vec![groups]
}
+pub fn get_object_store_options(
+ env: &mut JNIEnv,
+ map_object: JObject,
+) -> Result<HashMap<String, String>, CometError> {
+ let map = JMap::from_env(env, &map_object)?;
+ // Convert to a HashMap
+ let mut collected_map = HashMap::new();
+ // let mut iter = map.iter(&mut env)?;
Review Comment:
can this commented out code be removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
