changsun20 commented on PR #15696:
URL: https://github.com/apache/datafusion/pull/15696#issuecomment-2831631680
> Perhaps accessing fields of structs? eg:
>
> ```sql
> SELECT get_field({'x': null}, 'x') = null;
> ```
Thanks for pointing that out, I'll take that into consid
eliaperantoni commented on PR #15696:
URL: https://github.com/apache/datafusion/pull/15696#issuecomment-2821404985
> The warning detection is integrated during `BinaryExpr` processing, which
should naturally limit it to predicate contexts. Statements like `UPDATE users
SET password = NULL`
changsun20 commented on PR #15696:
URL: https://github.com/apache/datafusion/pull/15696#issuecomment-2807774575
> Thanks @changsun20 if I understood correctly #14434 is for emitting events
for the users, the same way it is done for Errors, but without halting the
query.
Thank you for
comphead commented on PR #15696:
URL: https://github.com/apache/datafusion/pull/15696#issuecomment-2806147068
Thanks @changsun20 if I understood correctly #14434 is for emitting events
for the users, the same way it is done for Errors, but without halting the
query.
--
This is an automat
changsun20 commented on PR #15696:
URL: https://github.com/apache/datafusion/pull/15696#issuecomment-2802985874
@comphead I understand your concern. If displaying warnings to end users is
what you'd like to see in this PR, could you confirm if @eliaperantoni's
proposed solution in #14434 of
comphead commented on PR #15696:
URL: https://github.com/apache/datafusion/pull/15696#issuecomment-2800125353
Yeah, that was actually my question having the warnings without being
returned to the end user, who is supposed to react on the warnings? 🤔
--
This is an automated message from t
changsun20 commented on PR #15696:
URL: https://github.com/apache/datafusion/pull/15696#issuecomment-2800081010
> Thanks @changsun20 wondering if its possible to test those warnings in
integration slt test files?
Thank you for the thoughtful question, @comphead. I appreciate your focu
changsun20 commented on PR #15696:
URL: https://github.com/apache/datafusion/pull/15696#issuecomment-2799781696
Hi @eliaperantoni,
Thank you for your patience and guidance throughout this issue. I've
implemented the core functionality per our discussions, but would like to
confirm a
changsun20 opened a new pull request, #15696:
URL: https://github.com/apache/datafusion/pull/15696
## Which issue does this PR close?
Closes #14434
## Rationale for this change
This PR addresses a common SQL anti-pattern where users accidentally use `=
NULL` instead of `
