changsun20 commented on PR #15696: URL: https://github.com/apache/datafusion/pull/15696#issuecomment-2800081010
> Thanks @changsun20 wondering if its possible to test those warnings in integration slt test files? Thank you for the thoughtful question, @comphead. I appreciate your focus on validation through integration tests. The current implementation prioritizes unit testing for the diagnostic infrastructure itself, as the warnings are collected internally via `SqlToRel` and not yet exposed through user-facing APIs. This approach allows us to validate the core logic while minimizing disruption to existing systems. I fully agree that end-to-end validation through `sqllogictest` becomes critical as we evolve toward a stable warning reporting interface. Building on the foundation from #14429, I'm committed to driving the design of a unified API surface for diagnostic propagation that would benefit both this implementation and future error reporting improvements. A follow-up ticket seems ideal to address these aspects systematically, ensuring we maintain both test coverage and architectural clarity. If the community prefers earlier integration testing, I'm happy to explore interim solutions - perhaps a temporary hook for test validation. Let me know your preference, and I'll adapt accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
