kazuyukitanimura merged PR #1943:
URL: https://github.com/apache/datafusion-comet/pull/1943
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsub
kazuyukitanimura commented on PR #1943:
URL:
https://github.com/apache/datafusion-comet/pull/1943#issuecomment-3029907146
Merged, thanks @andygrove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
andygrove commented on code in PR #1943:
URL: https://github.com/apache/datafusion-comet/pull/1943#discussion_r2180125789
##
docs/source/user-guide/expressions.md:
##
@@ -221,3 +221,4 @@ The following Spark expressions are currently available.
Any known compatibility
| Coalesc
kazuyukitanimura commented on code in PR #1943:
URL: https://github.com/apache/datafusion-comet/pull/1943#discussion_r2178797408
##
spark/src/main/scala/org/apache/comet/serde/unixtime.scala:
##
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
kazuyukitanimura commented on code in PR #1943:
URL: https://github.com/apache/datafusion-comet/pull/1943#discussion_r2178797235
##
spark/src/main/scala/org/apache/comet/serde/unixtime.scala:
##
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
kazuyukitanimura commented on code in PR #1943:
URL: https://github.com/apache/datafusion-comet/pull/1943#discussion_r2178796886
##
docs/spark_expressions_support.md:
##
@@ -175,7 +175,7 @@
- [ ] dayofweek
- [ ] dayofyear
- [x] extract
- - [ ] from_unixtime
+ - [x] from_un
kazuyukitanimura commented on code in PR #1943:
URL: https://github.com/apache/datafusion-comet/pull/1943#discussion_r2178797072
##
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##
@@ -1605,6 +1605,41 @@ class CometExpressionSuite extends CometTestBase with
andygrove commented on code in PR #1943:
URL: https://github.com/apache/datafusion-comet/pull/1943#discussion_r2177903855
##
spark/src/main/scala/org/apache/comet/serde/unixtime.scala:
##
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
andygrove commented on PR #1943:
URL:
https://github.com/apache/datafusion-comet/pull/1943#issuecomment-3024627259
Here is a suggested test to add to `CometFuzzTestSuite`:
```scala
test("from_unix_time") {
val df = spark.read.parquet(filename)
df.createOrReplaceTemp
andygrove commented on code in PR #1943:
URL: https://github.com/apache/datafusion-comet/pull/1943#discussion_r2177902711
##
spark/src/main/scala/org/apache/comet/serde/unixtime.scala:
##
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
andygrove commented on code in PR #1943:
URL: https://github.com/apache/datafusion-comet/pull/1943#discussion_r2177922388
##
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##
@@ -1605,6 +1605,41 @@ class CometExpressionSuite extends CometTestBase with
Adaptiv
andygrove commented on code in PR #1943:
URL: https://github.com/apache/datafusion-comet/pull/1943#discussion_r2177843634
##
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##
@@ -1605,6 +1605,41 @@ class CometExpressionSuite extends CometTestBase with
Adaptiv
andygrove commented on code in PR #1943:
URL: https://github.com/apache/datafusion-comet/pull/1943#discussion_r2177846050
##
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##
@@ -1605,6 +1605,41 @@ class CometExpressionSuite extends CometTestBase with
Adaptiv
andygrove commented on code in PR #1943:
URL: https://github.com/apache/datafusion-comet/pull/1943#discussion_r2177846951
##
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##
@@ -1605,6 +1605,41 @@ class CometExpressionSuite extends CometTestBase with
Adaptiv
andygrove commented on code in PR #1943:
URL: https://github.com/apache/datafusion-comet/pull/1943#discussion_r2177829049
##
docs/spark_expressions_support.md:
##
@@ -175,7 +175,7 @@
- [ ] dayofweek
- [ ] dayofyear
- [x] extract
- - [ ] from_unixtime
+ - [x] from_unixtime
kazuyukitanimura commented on code in PR #1943:
URL: https://github.com/apache/datafusion-comet/pull/1943#discussion_r2176135700
##
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##
@@ -1179,6 +1179,29 @@ object QueryPlanSerde extends Logging with CometExprShi
andygrove commented on code in PR #1943:
URL: https://github.com/apache/datafusion-comet/pull/1943#discussion_r2173423255
##
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##
@@ -1179,6 +1179,29 @@ object QueryPlanSerde extends Logging with CometExprShim
{
17 matches
Mail list logo
