andygrove commented on code in PR #1943:
URL: https://github.com/apache/datafusion-comet/pull/1943#discussion_r2177843634
##########
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##########
@@ -1605,6 +1605,41 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
}
}
+ test("from_unixtime") {
+ Seq(false, true).foreach { dictionary =>
+ withSQLConf("parquet.enable.dictionary" -> dictionary.toString) {
+ val table = "test"
+ withTempDir { dir =>
+ val path = new Path(dir.toURI.toString, "test.parquet")
+ makeParquetFileAllPrimitiveTypes(
+ path,
+ dictionaryEnabled = dictionary,
+ -128,
+ 128,
Review Comment:
It looks like the test is only testing a very small range of numbers (-32
through +32) if I am understanding this?
```scala
val data = (begin until end).map { i =>
if (nullEnabled && rand.nextBoolean()) {
None
} else {
if (dictionaryEnabled) Some(i % 4) else Some(i)
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
