github-actions[bot] closed pull request #15490: feat(sql): add diagnostic for
wrong number of function arguments
URL: https://github.com/apache/datafusion/pull/15490
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
github-actions[bot] commented on PR #15490:
URL: https://github.com/apache/datafusion/pull/15490#issuecomment-2961018338
Thank you for your contribution. Unfortunately, this pull request is stale
because it has been open 60 days with no activity. Please remove the stale
label or comment or
prowang01 commented on PR #15490:
URL: https://github.com/apache/datafusion/pull/15490#issuecomment-2767268386
> This PR has several CI failures so marking as a draft while they are
addressed. (I do this to make it easier to see what PRs are waiting on review)
Thank you for the feedba
alamb commented on PR #15490:
URL: https://github.com/apache/datafusion/pull/15490#issuecomment-2767072034
This PR has several CI failures so marking as a draft while they are
addressed.
(I do this to make it easier to see what PRs are waiting on review)
--
This is an automated messa
prowang01 commented on PR #15490:
URL: https://github.com/apache/datafusion/pull/15490#issuecomment-2768371753
Hey @eliaperantoni,
Thanks for the detailed review. I totally understand your concerns and just
wanted to say I’m really sorry if my work came across as rushed or dishonest —
eliaperantoni commented on PR #15490:
URL: https://github.com/apache/datafusion/pull/15490#issuecomment-2768344530
I think this issue is being planned and discussed in a much more robust and
future proof way by @Chen-Yuan-Lai and @dentiny in #14432
--
This is an automated message from the
eliaperantoni commented on PR #15490:
URL: https://github.com/apache/datafusion/pull/15490#issuecomment-2768341633
Also you made the PR ready for review again, after @alamb, made it a draft,
without first committing any new changes?
--
This is an automated message from the Apache Git Serv
eliaperantoni commented on code in PR #15490:
URL: https://github.com/apache/datafusion/pull/15490#discussion_r2022232702
##
datafusion/common/src/utils/mod.rs:
##
@@ -979,16 +981,19 @@ pub fn take_function_args(
) -> Result<[T; N]> {
let args = args.into_iter().collect::>
alamb commented on PR #15490:
URL: https://github.com/apache/datafusion/pull/15490#issuecomment-2764498764
FYI @eliaperantoni
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
prowang01 opened a new pull request, #15490:
URL: https://github.com/apache/datafusion/pull/15490
## Which issue does this PR close?
Closes #14432
Relates to #14429
## Rationale for this change
This PR adds a user-facing diagnostic when a SQL function is called with
10 matches
Mail list logo
