prowang01 commented on PR #15490: URL: https://github.com/apache/datafusion/pull/15490#issuecomment-2768371753
Hey @eliaperantoni, Thanks for the detailed review. I totally understand your concerns and just wanted to say I’m really sorry if my work came across as rushed or dishonest — that was absolutely not my intention. I’m currently in the middle of my exams, and I tried to make some progress on this PR in my limited free time. I realize now that some of my assumptions were wrong, especially the hardcoded logic — I just wanted to get a minimal proof-of-concept running, thinking I’d improve things after or with guidance. I also clicked “Ready for review” by mistake — I didn’t know it would ping people without confirmation, so that’s on me too. I still want to contribute properly, but I may need to pause for a bit and come back with a better understanding and cleaner PR — possibly aligned with the work in #14432. I really appreciate your feedback and hope I can make a better contribution soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
