comphead merged PR #14026:
URL: https://github.com/apache/datafusion/pull/14026
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
nuno-faria commented on code in PR #14026:
URL: https://github.com/apache/datafusion/pull/14026#discussion_r1907601841
##
datafusion/optimizer/src/push_down_filter.rs:
##
@@ -1442,6 +1513,227 @@ mod tests {
assert_optimized_plan_eq(plan, expected)
}
+/// veri
nuno-faria commented on code in PR #14026:
URL: https://github.com/apache/datafusion/pull/14026#discussion_r1907597367
##
datafusion/optimizer/src/push_down_filter.rs:
##
@@ -985,6 +985,77 @@ impl OptimizerRule for PushDownFilter {
}
alamb commented on code in PR #14026:
URL: https://github.com/apache/datafusion/pull/14026#discussion_r1907385995
##
datafusion/optimizer/Cargo.toml:
##
@@ -43,6 +43,7 @@ arrow = { workspace = true }
chrono = { workspace = true }
datafusion-common = { workspace = true, default
nuno-faria commented on code in PR #14026:
URL: https://github.com/apache/datafusion/pull/14026#discussion_r1906820538
##
datafusion/optimizer/src/push_down_filter.rs:
##
@@ -985,6 +985,77 @@ impl OptimizerRule for PushDownFilter {
}
nuno-faria commented on code in PR #14026:
URL: https://github.com/apache/datafusion/pull/14026#discussion_r1906812252
##
datafusion/optimizer/src/push_down_filter.rs:
##
@@ -985,6 +985,77 @@ impl OptimizerRule for PushDownFilter {
}
2010YOUY01 commented on code in PR #14026:
URL: https://github.com/apache/datafusion/pull/14026#discussion_r1906209324
##
datafusion/optimizer/src/push_down_filter.rs:
##
@@ -985,6 +985,77 @@ impl OptimizerRule for PushDownFilter {
}
alamb commented on PR #14026:
URL: https://github.com/apache/datafusion/pull/14026#issuecomment-2576259000
This looks amazing @nuno-faria -- thanks you -- I plan to review it
carefully tomorrow
--
This is an automated message from the Apache Git Service.
To respond to the message, please
comphead commented on PR #14026:
URL: https://github.com/apache/datafusion/pull/14026#issuecomment-2574160403
Thats a really nice idea, thanks @nuno-faria
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
nuno-faria opened a new pull request, #14026:
URL: https://github.com/apache/datafusion/pull/14026
Ensures selections can be pushed past window functions, similarly to what is
already done with aggregations, when possible.
Unlike aggregations, however, extra care must be taken when handli
10 matches
Mail list logo
