andygrove merged PR #1380:
URL: https://github.com/apache/datafusion-comet/pull/1380
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@
andygrove commented on code in PR #1380:
URL: https://github.com/apache/datafusion-comet/pull/1380#discussion_r1952928795
##
spark/src/main/scala/org/apache/comet/serde/aggregates.scala:
##
@@ -0,0 +1,734 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
andygrove commented on PR #1380:
URL:
https://github.com/apache/datafusion-comet/pull/1380#issuecomment-2654127513
> It's hard to spot the two functional changes made in this PR because of
the large amount of code moved. Can you tag the places where the changes were
made?
Sure, func
parthchandra commented on PR #1380:
URL:
https://github.com/apache/datafusion-comet/pull/1380#issuecomment-2652630092
It's hard to spot the two functional changes made in this PR because of the
large amount of code moved. Can you tag the places where the changes were made?
--
This is an
kazuyukitanimura commented on code in PR #1380:
URL: https://github.com/apache/datafusion-comet/pull/1380#discussion_r1951852554
##
spark/src/main/scala/org/apache/comet/serde/aggregates.scala:
##
@@ -0,0 +1,734 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
codecov-commenter commented on PR #1380:
URL:
https://github.com/apache/datafusion-comet/pull/1380#issuecomment-2645976629
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
andygrove opened a new pull request, #1380:
URL: https://github.com/apache/datafusion-comet/pull/1380
## Which issue does this PR close?
Part of https://github.com/apache/datafusion-comet/issues/1345
## Rationale for this change
Refactor in preparation for
