andygrove opened a new pull request, #1380: URL: https://github.com/apache/datafusion-comet/pull/1380
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> Part of https://github.com/apache/datafusion-comet/issues/1345 ## Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> Refactor in preparation for improving type checking and testing for aggregate expressions. ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> Move aggregate expression serde into individual classes This is mostly just moving code around. There are only two functional changes: 1. Previously, we had match arms such as `case max @ Max(child) if minMaxDataTypeSupported(max.dataType) =>` which meant that if the type was not supported then we would fall through to the `case _` arm which would report `unsupported Spark aggregate function`, which is misleading. We now do the type checks withing the aggregate serde logic and report `unsupported data type` for the aggregate instead. 2. I made some small changes to the type checks because the existing code checked for `NumericType` rather than the specific types that we actually support, so I made this more explicit. We do not support `FractionalType`, for example, and this is a child of `NumericType`. ## How are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 3. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> Existing tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
