Re: [PR] chore: Reduce number of runs of Rust unit tests in CI [datafusion-comet]

2025-03-11 Thread via GitHub
codecov-commenter commented on PR #1481: URL: https://github.com/apache/datafusion-comet/pull/1481#issuecomment-2705154485 ## [Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1481?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca

Re: [PR] chore: Reduce number of runs of Rust unit tests in CI [datafusion-comet]

2025-03-09 Thread via GitHub
andygrove commented on PR #1481: URL: https://github.com/apache/datafusion-comet/pull/1481#issuecomment-2708890026 We don't need to test Rust with different Scala and Spark versions. I will revisit this PR another day. Thanks for the reviews, @kazuyukitanimura. -- This is an automated me

Re: [PR] chore: Reduce number of runs of Rust unit tests in CI [datafusion-comet]

2025-03-09 Thread via GitHub
andygrove commented on code in PR #1481: URL: https://github.com/apache/datafusion-comet/pull/1481#discussion_r1986330188 ## .github/workflows/pr_build.yml: ## @@ -40,12 +40,31 @@ env: RUST_VERSION: stable jobs: + linux-test-rust: +strategy: + matrix: +os

Re: [PR] chore: Reduce number of runs of Rust unit tests in CI [datafusion-comet]

2025-03-09 Thread via GitHub
andygrove commented on PR #1481: URL: https://github.com/apache/datafusion-comet/pull/1481#issuecomment-2708887119 @kazuyukitanimura It looks like I had misunderstood this. The rust tests actually do have some tests that interact with the JVM to load classes. I did not realize this until n

Re: [PR] chore: Reduce number of runs of Rust unit tests in CI [datafusion-comet]

2025-03-09 Thread via GitHub
andygrove closed pull request #1481: chore: Reduce number of runs of Rust unit tests in CI URL: https://github.com/apache/datafusion-comet/pull/1481 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] chore: Reduce number of runs of Rust unit tests in CI [datafusion-comet]

2025-03-09 Thread via GitHub
andygrove commented on code in PR #1481: URL: https://github.com/apache/datafusion-comet/pull/1481#discussion_r1986331195 ## .github/workflows/pr_build.yml: ## @@ -40,12 +40,31 @@ env: RUST_VERSION: stable jobs: + linux-test-rust: +strategy: + matrix: +os

Re: [PR] chore: Reduce number of runs of Rust unit tests in CI [datafusion-comet]

2025-03-09 Thread via GitHub
andygrove commented on code in PR #1481: URL: https://github.com/apache/datafusion-comet/pull/1481#discussion_r1986330188 ## .github/workflows/pr_build.yml: ## @@ -40,12 +40,31 @@ env: RUST_VERSION: stable jobs: + linux-test-rust: +strategy: + matrix: +os

Re: [PR] chore: Reduce number of runs of Rust unit tests in CI [datafusion-comet]

2025-03-09 Thread via GitHub
andygrove commented on code in PR #1481: URL: https://github.com/apache/datafusion-comet/pull/1481#discussion_r1986329465 ## .github/workflows/pr_build.yml: ## @@ -182,20 +207,29 @@ jobs: with: rust-version: ${{env.RUST_VERSION}} jdk-version: ${{ m

Re: [PR] chore: Reduce number of runs of Rust unit tests in CI [datafusion-comet]

2025-03-09 Thread via GitHub
andygrove commented on code in PR #1481: URL: https://github.com/apache/datafusion-comet/pull/1481#discussion_r1986329258 ## .github/workflows/pr_build.yml: ## @@ -40,12 +40,31 @@ env: RUST_VERSION: stable jobs: + linux-test-rust: +strategy: + matrix: +os

Re: [PR] chore: Reduce number of runs of Rust unit tests in CI [datafusion-comet]

2025-03-08 Thread via GitHub
kazuyukitanimura commented on code in PR #1481: URL: https://github.com/apache/datafusion-comet/pull/1481#discussion_r1986199136 ## .github/workflows/pr_build.yml: ## @@ -40,12 +40,31 @@ env: RUST_VERSION: stable jobs: + linux-test-rust: +strategy: + matrix: +

[PR] chore: Reduce number of runs of Rust unit tests in CI [datafusion-comet]

2025-03-07 Thread via GitHub
andygrove opened a new pull request, #1481: URL: https://github.com/apache/datafusion-comet/pull/1481 ## Which issue does this PR close? Closes https://github.com/apache/datafusion-comet/issues/1480 ## Rationale for this change ## What changes are included