kazuyukitanimura commented on code in PR #1481:
URL: https://github.com/apache/datafusion-comet/pull/1481#discussion_r1986199136
##########
.github/workflows/pr_build.yml:
##########
@@ -40,12 +40,31 @@ env:
RUST_VERSION: stable
jobs:
+ linux-test-rust:
+ strategy:
+ matrix:
+ os: [ubuntu-latest]
+ is_push_event:
+ - ${{ github.event_name == 'push' }}
+ fail-fast: false
+ name: ${{ matrix.os }}/rust
+ runs-on: ${{ matrix.os }}
+ container:
+ image: amd64/rust
+ steps:
+ - uses: actions/checkout@v4
+ - name: Setup Rust & Java toolchain
+ uses: ./.github/actions/setup-builder
+ with:
+ rust-version: ${{env.RUST_VERSION}}
+ - name: Rust test steps
+ uses: ./.github/actions/rust-test
Review Comment:
What about `upload-test-reports`?
##########
.github/workflows/pr_build.yml:
##########
@@ -40,12 +40,31 @@ env:
RUST_VERSION: stable
jobs:
+ linux-test-rust:
+ strategy:
+ matrix:
+ os: [ubuntu-latest]
+ is_push_event:
+ - ${{ github.event_name == 'push' }}
+ fail-fast: false
+ name: ${{ matrix.os }}/rust
+ runs-on: ${{ matrix.os }}
+ container:
+ image: amd64/rust
+ steps:
+ - uses: actions/checkout@v4
+ - name: Setup Rust & Java toolchain
Review Comment:
The name still has `Java`
##########
.github/workflows/pr_build.yml:
##########
@@ -182,20 +207,29 @@ jobs:
with:
rust-version: ${{env.RUST_VERSION}}
jdk-version: ${{ matrix.java_version }}
- - if: matrix.test-target == 'rust'
- name: Rust test steps
- uses: ./.github/actions/rust-test
- - if: matrix.test-target == 'java'
- name: Java test steps
+ - name: Java test steps
uses: ./.github/actions/java-test
with:
maven_opts: -Pspark-${{ matrix.spark-version }},scala-${{
matrix.scala-version }}
+ macos-aarch64-test-rust:
+ name: macos-14(Silicon)/rust
Review Comment:
`fail-fast: false` is missing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
