andygrove commented on PR #958:
URL: https://github.com/apache/datafusion-comet/pull/958#issuecomment-2960628775
I am closing this PR since it is no longer active. Feel free to re-open if
needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
andygrove closed pull request #958: chore: Override node name for
CometSparkToColumnar
URL: https://github.com/apache/datafusion-comet/pull/958
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
andygrove commented on PR #1577:
URL:
https://github.com/apache/datafusion-comet/pull/1577#issuecomment-2766924919
> Previous PR: #958 I noticed that collecting dataframe directly from
parquet causes an error. From what I see the problem lies in converting
Columnar back to Row. If that's s
andygrove merged PR #1577:
URL: https://github.com/apache/datafusion-comet/pull/1577
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@
codecov-commenter commented on PR #1577:
URL:
https://github.com/apache/datafusion-comet/pull/1577#issuecomment-2762138134
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1577?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
l0kr commented on PR #1577:
URL:
https://github.com/apache/datafusion-comet/pull/1577#issuecomment-2761641254
Previous PR: #958
I noticed that collecting dataframe directly from parquet causes an error.
From what I see the problem lies in converting Columnar back to Row. If that's
some
l0kr opened a new pull request, #1577:
URL: https://github.com/apache/datafusion-comet/pull/1577
## Which issue does this PR close?
Closes #936.
## Rationale for this change
Previous PR went stale so I wanted to move it forward.
## What changes are included
andygrove commented on code in PR #958:
URL: https://github.com/apache/datafusion-comet/pull/958#discussion_r1846868142
##
spark/src/test/scala/org/apache/comet/exec/CometExecSuite.scala:
##
@@ -1707,6 +1707,29 @@ class CometExecSuite extends CometTestBase {
}
}
+ tes
JensonChoi commented on code in PR #958:
URL: https://github.com/apache/datafusion-comet/pull/958#discussion_r1837756417
##
spark/src/test/scala/org/apache/comet/exec/CometExecSuite.scala:
##
@@ -1707,6 +1707,29 @@ class CometExecSuite extends CometTestBase {
}
}
+ te
andygrove commented on code in PR #958:
URL: https://github.com/apache/datafusion-comet/pull/958#discussion_r1822970181
##
spark/src/test/scala/org/apache/comet/exec/CometExecSuite.scala:
##
@@ -1707,6 +1707,29 @@ class CometExecSuite extends CometTestBase {
}
}
+ tes
andygrove commented on PR #958:
URL: https://github.com/apache/datafusion-comet/pull/958#issuecomment-2447678277
> And they all passed. In addition, I briefly looked at the stability test
suites
[here](https://github.com/apache/datafusion-comet/tree/d670af7aba4aa9bfa99c11ec1d0cd8fee15b4410/
JensonChoi commented on PR #958:
URL: https://github.com/apache/datafusion-comet/pull/958#issuecomment-2440987083
@andygrove I reran the following commands without the
`SPARK_GENERATE_GOLDEN_FILES=1` flag:
```
make clean; make release PROFILES="-Pspark-3.4"
./mvnw -pl spark
-Dsuite
JensonChoi commented on PR #958:
URL: https://github.com/apache/datafusion-comet/pull/958#issuecomment-2434544381
`SPARK_HOME` is currently set to `/home/jenson/datafusion-comet`, which is
my local clone of the repo. Does that sound about right? I will try the logging
route that you suggest
andygrove commented on PR #958:
URL: https://github.com/apache/datafusion-comet/pull/958#issuecomment-2429644474
> @andygrove Following our discussions on Discord, I ran the following
commands to update the golden files.
>
> ```
> make clean; make release PROFILES="-Pspark-3.4"
JensonChoi commented on PR #958:
URL: https://github.com/apache/datafusion-comet/pull/958#issuecomment-2424735579
@andygrove Following our discussions on Discord, I ran the following
commands to update the golden files.
```
make clean; make release PROFILES="-Pspark-3.4"
SPARK_GENER
15 matches
Mail list logo
