JensonChoi commented on PR #958: URL: https://github.com/apache/datafusion-comet/pull/958#issuecomment-2440987083
@andygrove I reran the following commands without the `SPARK_GENERATE_GOLDEN_FILES=1` flag: ``` make clean; make release PROFILES="-Pspark-3.4" ./mvnw -pl spark -Dsuites="org.apache.spark.sql.comet.CometTPCDSV1_4_PlanStabilitySuite" -Pspark-3.4 -nsu test ./mvnw -pl spark -Dsuites="org.apache.spark.sql.comet.CometTPCDSV2_7_PlanStabilitySuite" -Pspark-3.4 -nsu test make clean; make release PROFILES="-Pspark-3.5" ./mvnw -pl spark -Dsuites="org.apache.spark.sql.comet.CometTPCDSV1_4_PlanStabilitySuite" -Pspark-3.5 -nsu test ./mvnw -pl spark -Dsuites="org.apache.spark.sql.comet.CometTPCDSV2_7_PlanStabilitySuite" -Pspark-3.5 -nsu test make clean; make release PROFILES="-Pspark-4.0" ./mvnw -pl spark -Dsuites="org.apache.spark.sql.comet.CometTPCDSV1_4_PlanStabilitySuite" -Pspark-4.0 -nsu test ./mvnw -pl spark -Dsuites="org.apache.spark.sql.comet.CometTPCDSV2_7_PlanStabilitySuite" -Pspark-4.0 -nsu test ``` And they all passed. In addition, I briefly looked at the stability test suites [here](https://github.com/apache/datafusion-comet/tree/d670af7aba4aa9bfa99c11ec1d0cd8fee15b4410/spark/src/test/resources/tpcds-plan-stability), and it appears none of them contains the node `CometSparkToColumnar`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
