Re: [PR] chore: Minor code cleanup in native scan type checking [datafusion-comet]

2025-03-16 Thread via GitHub
andygrove commented on PR #1537: URL: https://github.com/apache/datafusion-comet/pull/1537#issuecomment-2727488196 These changes are now included in https://github.com/apache/datafusion-comet/pull/1483 -- This is an automated message from the Apache Git Service. To respond to the message

Re: [PR] chore: Minor code cleanup in native scan type checking [datafusion-comet]

2025-03-16 Thread via GitHub
andygrove closed pull request #1537: chore: Minor code cleanup in native scan type checking URL: https://github.com/apache/datafusion-comet/pull/1537 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] chore: Minor code cleanup in native scan type checking [datafusion-comet]

2025-03-15 Thread via GitHub
andygrove commented on code in PR #1537: URL: https://github.com/apache/datafusion-comet/pull/1537#discussion_r1997192540 ## spark/src/test/scala/org/apache/comet/parquet/ParquetReadSuite.scala: ## @@ -82,11 +82,7 @@ abstract class ParquetReadSuite extends CometTestBase { }

Re: [PR] chore: Minor code cleanup in native scan type checking [datafusion-comet]

2025-03-15 Thread via GitHub
codecov-commenter commented on PR #1537: URL: https://github.com/apache/datafusion-comet/pull/1537#issuecomment-2726800741 ## [Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1537?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca

Re: [PR] chore: Minor code cleanup in native scan type-checking [datafusion-comet]

2025-03-15 Thread via GitHub
andygrove commented on code in PR #1537: URL: https://github.com/apache/datafusion-comet/pull/1537#discussion_r1997045440 ## spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala: ## @@ -199,15 +199,15 @@ class CometSparkSessionExtensions _,

[PR] chore: Minor code cleanup in native scan type-checking [datafusion-comet]

2025-03-15 Thread via GitHub
andygrove opened a new pull request, #1537: URL: https://github.com/apache/datafusion-comet/pull/1537 ## Which issue does this PR close? N/A ## Rationale for this change Unify code for `native_datafusion` and `native_iceberg_compat` when checking for supp