andygrove commented on code in PR #1537:
URL: https://github.com/apache/datafusion-comet/pull/1537#discussion_r1997045440
##########
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##########
@@ -199,15 +199,15 @@ class CometSparkSessionExtensions
_,
_,
_)
- if CometScanExec.isFileFormatSupported(fileFormat)
+ if COMET_EXEC_ENABLED.get()
+ && CometConf.isExperimentalNativeScan
Review Comment:
I moved this check earlier because it is much cheaper than checking if the
schema is supported (especially if the schema is deeply nested)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
