Re: [PR] bug: Remove array_slice two arg variant [datafusion]

2025-02-06 Thread via GitHub
alamb merged PR #14527: URL: https://github.com/apache/datafusion/pull/14527 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusi

Re: [PR] bug: Remove array_slice two arg variant [datafusion]

2025-02-06 Thread via GitHub
alamb commented on code in PR #14527: URL: https://github.com/apache/datafusion/pull/14527#discussion_r1945314693 ## datafusion/sqllogictest/test_files/array.slt: ## @@ -1850,15 +1850,11 @@ select array_slice(arrow_cast(make_array(1, 2, 3, 4, 5), 'LargeList(Int64)'), 0, [] []

[PR] bug: Remove array_slice two arg variant [datafusion]

2025-02-06 Thread via GitHub
jkosh44 opened a new pull request, #14527: URL: https://github.com/apache/datafusion/pull/14527 In 3dfce7d33c19d6e7941b58cb7e83194c066347ca I misunderstood an existing test and accidentally added a variant of `array_slice` that accepts two arguments. This variant is not valid and only works