alamb commented on code in PR #14527:
URL: https://github.com/apache/datafusion/pull/14527#discussion_r1945314693


##########
datafusion/sqllogictest/test_files/array.slt:
##########
@@ -1850,15 +1850,11 @@ select array_slice(arrow_cast(make_array(1, 2, 3, 4, 
5), 'LargeList(Int64)'), 0,
 [] []
 
 # array_slice scalar function #11 (with NULL-NULL)
-query ??

Review Comment:
   This is consistent with duckdb too 👍 
   
   ```sql
   D select array_slice([1,2,3], null);
   Binder Error: No function matches the given name and argument types 
'array_slice(INTEGER[], "NULL")'. You might need to add explicit type casts.
        Candidate functions:
        array_slice(ANY, ANY, ANY) -> ANY
        array_slice(ANY, ANY, ANY, BIGINT) -> ANY
   
   LINE 1: select array_slice([1,2,3], null);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to